Improve Prev/Next Img status bar button behavior #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically `<` and `>` in status bar used to cause the Adjust Page Markers dialog to be popped, and the "previous" and "next" image moved to were actually the ones before/after the one displayed in that dialog, regardless of where the cursor was in the file. Now that the dialog is not popped, these buttons should go back/forward a page from the current location. This had a bug, due to combining `my` with `if`, so location wasn't reset properly, and back/forward remembered where it had previously gone even if the cursor had moved. Behavior now consistent, with only complication being when there are 2 coincident page markers, when it has to jump over them both, since there is no location in the file that lies between them. Fixes DistributedProofreaders#1269
srjfoo
approved these changes
Oct 25, 2023
cpeel
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically
<and>in status bar used to cause the Adjust Page Markers dialog to be popped, and the "previous" and "next" image moved to were actually the ones before/after the one displayed in that dialog, regardless of where the cursor was in the file.Now that the dialog is not popped, these buttons should go back/forward a page from the current location. This had a bug, due to combining
mywithif, so location wasn't reset properly, and back/forward remembered where it had previously gone even if the cursor had moved.Behavior now consistent, with only complication being when there are 2 coincident page markers, when it has to jump over them both, since there is no location in the file that lies between them.
Fixes #1269